[U-Boot-Users] [PATCH 1/3] Initial OneNAND support

Kyungmin Park kmpark at infradead.org
Thu Mar 15 01:43:57 CET 2007

Dear Wolfgang Denk,

> > 
> > This patch supports OneNAND device on U-Boot.
> > The most codes are based on OneNAND MTD in kernel.
> Your patches have a few cosing style issues (indentation not 
> by TAB's, trailing white space). Please clean up and 
> resubmet; see also http://www.denx.de/wiki/UBoot/CodingStyle

Thank you, I use the 'indent' programe to fix indentation

> Also, please restrict your line length no around 70 characters or so.

Since its code based on kernel and consistent with kernel. it has almost
same syntax.

> And can you please add a GPL license header to 
> onenand/onenand_bbt.c, include/linux/mtd/bbm.h

I added it.

> > For better performance I added 32-bytes aligned memcpy32. 
> > Pleae check it.
> Did you measure how much of performance  this  gains?  Is  it 
>  really worth the effort? In any case, the file needs a GPL 
> license header.

we can feel that it's more faster than before. OK I added GPL license

Thank you,
Kyungmin Park

More information about the U-Boot mailing list