[U-Boot-Users] [PATCH 1/3] Initial OneNAND support

Wolfgang Denk wd at denx.de
Thu Mar 15 02:09:31 CET 2007

In message <000101c7669b$0e776c20$c7a3580a at swcenter.sec.samsung.co.kr> you wrote:
> > resubmet; see also http://www.denx.de/wiki/UBoot/CodingStyle
> Thank you, I use the 'indent' programe to fix indentation

You may want to use "Lindent -pcs" instead, see
as mentioned above.

> > Also, please restrict your line length no around 70 characters or so.
> Since its code based on kernel and consistent with kernel. it has almost
> same syntax.

So what?

> > > For better performance I added 32-bytes aligned memcpy32. 
> > > Pleae check it.
> > 
> > Did you measure how much of performance  this  gains?  Is  it 
> >  really worth the effort? In any case, the file needs a GPL 
> > license header.
> we can feel that it's more faster than before. OK I added GPL license

How much? 5%? 20%? 50%?

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Hello! I'm from outer space,  and I've made myself look like a signa-
ture.  While  you  are reading this, I'm having sex with your eyes. I
know it feels good to you, because you're smiling. I'm very horny, so
send me to someone else when you've had enough. Thanks!
                              Sincerely, A Stranger in a Strange Land

More information about the U-Boot mailing list