[U-Boot-Users] [PATCH 1/3] Initial OneNAND support

[Kyungmin Park]

> > > Also, please restrict your line length no around 70 
> characters or so.
> > 
> > Since its code based on kernel and consistent with kernel. it has 
> > almost same syntax.
> 
> So what?

To maintain easily. as mentioned it's the first version of OneNAND driver
in kernel. it's code is almost same in kernel 2.6.15.
After release I changed a lots of code. I will update it for OneNAND on U-
Boot.

> Indentation not by TABs, trailing white space.

I changed it using 's/^  /^ /g', 's/ $/$/g'. 

> 
> > > > For better performance I added 32-bytes aligned memcpy32. 
> > > > Pleae check it.
> > > 
> > > Did you measure how much of performance  this  gains?  Is  it  
> > > really worth the effort? In any case, the file needs a 
> GPL license 
> > > header.
> > 
> > we can feel that it's more faster than before. OK I added 
> GPL license
> 
> How much? 5%? 20%? 50%?

Architecture optimized copy is fast about 3 times in OMAP 16xx series (ARM
9 core) in U-Boot

Here's test results
memory copy (Unit: nsec)	              96 MHz		192 MHz
unsigned long *	                          189,440 ~ 192,000	158,720 ~
160,000 
architecture optimized copy	              56,320 ~ 58,880	53,760 ~ 55,
040

where increment time is 2560 nsec in 96 MHz and 1280 nsec in 192 MHz

Thank you,
Kyungmin Park