[U-Boot-Users] [PATCH] Fix the condition to detect if an image is already in its place

Wolfgang Denk wd at denx.de
Wed Mar 21 22:36:25 CET 2007


In message <20070321211706.GA17632 at informatik.uni-freiburg.de> you wrote:
> 
> > That's exactly the test that is used to decide  if  we  have  an  XIP
> > image:  if  the  load  address  is identical to the address where the
> > image is currently stored, it will not be  copied,  but  executed  in
> > place.
> In my eyes it would be more clear if an XIP image had 
> 
> 	ih_load = xip_address + sizeof(header)
> 
> because then the load address would have the same meaning for both XIP
> and non-XIP.  Now it's somehow artifical that I cannot load an non-XIP
> image (with header) to it's load address.  

That's not the way how it's been implemented more than 5 years ago.

> > And, as mentioned before, your modification will  break  this  logic,
> > this breaking booting XIP images on PowerPC.
> I got that.  As XIP booting on PowerPC relies on an---in my
> eyes---broken feature it has to be fixed of course after that feature is
> fixed.

You are welcome to submit patches  to  support XIP  with  ARCH=powerpc
Linux kernels! [And yes, I will then even happily drop backwards
compatibility with old 2.4.4 kernels - which is something I don't do
light-heartedly ;-)  ]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Landru! Guide us!
	-- A Beta 3-oid, "The Return of the Archons", stardate 3157.4




More information about the U-Boot mailing list