[U-Boot-Users] [PPC4xx] Please pull git://www.denx.de/git/u-boot-ppc4xx.git

[Stefan Roese]

Hi Wolfgang,

On Wednesday 21 March 2007 23:28, Wolfgang Denk wrote:
> Ummm... can you please be a bit more careful regarding coding style
> issues? I had to clean up trailing white space in
> board/amcc/acadia/config.mk and board/amcc/acadia/flash.c;
> indentation not by TABs in board/amcc/acadia/cpr.c;
> bad brace style in board/amcc/acadia/memory.c;
> and excessive
> newlines in board/amcc/acadia/memory.c

I know that this code badly needs some cleanup. This is why I added this to 
the commit text:

Commit: 16c0cc1c82081a493ab87c51980b28336ce1bce8
Author: Stefan Roese <sr at denx.de> Wed, 21 Mar 2007 13:39:57 +0100

    [PATCH] Add AMCC Acadia (405EZ) eval board support

    This patch adds support for the new AMCC Acadia eval board.

    Please note that this Acadia/405EZ support is still in a beta stage.
    Still lot's of cleanup needed but we need a preliminary release now.

    Signed-off-by: Stefan Roese <sr at denx.de>

Commit: e01bd218b00af73499331a1a701625a852cd286f
Author: Stefan Roese <sr at denx.de> Wed, 21 Mar 2007 13:38:59 +0100

    [PATCH] Add AMCC PPC405EZ support

    This patch adds support for the new AMCC 405EZ PPC. It is in
    preparation for the AMCC Acadia board support.

    Please note that this Acadia/405EZ support is still in a beta stage.
    Still lot's of cleanup needed but we need a preliminary release now.

    Signed-off-by: Stefan Roese <sr at denx.de>


I will do this cleanup in the next week, when I have a little more time.

> I did not clean up some "#if 1" / "#endif" and  "#if  0"  /  "#endif"
> areas. Please do this yourself.

Yes, I know of all this. Next week.

> Also, "board/amcc/acadia/memory.c" has some strange comments. Please
> clean up.

Sure.

> Why do you return a hard-coded size in cram_init()? I would  like  to
> see dynamic sizing like we use in all other systems...

Again, next week. I promise.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
=====================================================================