[U-Boot-Users] [PATCH] cfi_flash.c: use addr2info

[Tolunay Orkun]

Ladislav Michl wrote:
> On Wed, May 02, 2007 at 04:50:48PM -0500, Tolunay Orkun wrote:
>> I looked at your patch when you submitted but did not carefully review 
>> yet. I feel like the function should reside inside the flash driver 
>> where it is most often used and flash driver should export it.
> 
> I disagree. This function (addr2info) is used also by board specific
> drivers as well as by common/cmd_load.c, common/cmd_bootm.c and
> common/cmd_mem.c. Therefore it should reside in common/flash.c - to
> be used by either board specific driver or cfi driver.
> 
> Best regards,
> 	ladis

Landis,

I was referring to the frequency of the use of the function during flash 
programming. I am use it is called elsewhere but when the function is in 
the same file compiler has more opportunities to optimize. That is why I 
prefer the function stay in the flash driver and exported from there.

Tolunay