[U-Boot-Users] [PATCH] cfi_flash.c: use addr2info

[Stefan Roese]

On Wednesday 16 May 2007, Ladislav Michl wrote:
> On Thu, May 03, 2007 at 04:06:16PM -0500, Tolunay Orkun wrote:
> > I was referring to the frequency of the use of the function during flash
> > programming. I am use it is called elsewhere but when the function is in
> > the same file compiler has more opportunities to optimize. That is why I
> > prefer the function stay in the flash driver and exported from there.
>
> In drivers/cfi_flash.c flash_get_info (alias addr2info) is called only from
> flash_init. So what "frequency of the use" are you referring to? There
> is not only CFI driver, some boards have their own flash drivers. Do you
> want them to provide another variant of this function? Or use the one
> from flash.c? Why cannot cfi_flash.c use it as well?

Sounds reasonable to me. Just me 2 cents.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================