[U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx CFG_RAMBOOT

[Timur Tabi]

Nikita V. Youshchenko wrote:

> I guess I'm not alone in such a situation. So please don't remove ramboot 
> support.

Ok, I'll keep it.  But I think you need to expand your patch to fix this problem:

    #define CFG_ENV_ADDR		(CFG_MONITOR_BASE - 0x1000)
    #define CFG_ENV_SIZE		0x2000

The environment is located 0x1000 bytes before the start of U-Boot, but 0x2000 bytes have 
been reserved.

Your patch should probably change the above lines to:

    #define CFG_ENV_SIZE		0x2000
    #define CFG_ENV_ADDR		(CFG_MONITOR_BASE - CFG_ENV_SIZE)

However, Wolfgang says this is still wrong, but he won't explain why.  What do you think?

> Could you please explain what you mean?
> 
> I don't put CONFIG_COMMANDS under #ifdef.

Sorry, I misread your patch.  I have a crappy monitor.

> I put another macro, CONFIG_COMMANDS_DEFAULT, under ifdef.
> And then use it in unconditional CONFIG_COMMANDS definition.
> Looks similar to CONFIG_COMMANDS_CF and others.
> The difference from CONFIG_COMMANDS_CF is that I have to exclude bits from 
> CONFIG_CMD_DFL, not add more commands.

Ok, I understand now.  This part is fine.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale