[U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx CFG_RAMBOOT

[Wolfgang Denk]

In message <465463E1.6050000 at freescale.com> you wrote:
> 
>     #define CFG_ENV_SIZE		0x2000
>     #define CFG_ENV_ADDR		(CFG_MONITOR_BASE - CFG_ENV_SIZE)
> 
> However, Wolfgang says this is still wrong, but he won't explain why.  What do you think?

Timur, did you really check the code?

See for example:

"include/configs/MPC8349ITX.h":
    404 #ifndef CFG_RAMBOOT
    ...
    409 #else
    410   #define CFG_NO_FLASH          /* Flash is not usable now */
==> 411   #define CFG_ENV_IS_NOWHERE    /* Store ENV in memory only */
    412   #define CFG_ENV_ADDR          (CFG_MONITOR_BASE - 0x1000)
    413   #define CFG_ENV_SIZE          0x2000
    414 #endif

and

"common/cmd_nvedit.c":

    541 #if defined(CFG_ENV_IS_IN_NVRAM) || defined(CFG_ENV_IS_IN_EEPROM) || \
    542     ((CONFIG_COMMANDS & (CFG_CMD_ENV|CFG_CMD_FLASH)) == \
    543       (CFG_CMD_ENV|CFG_CMD_FLASH)) || \
    544     ((CONFIG_COMMANDS & (CFG_CMD_ENV|CFG_CMD_NAND)) == \
    545       (CFG_CMD_ENV|CFG_CMD_NAND))
    546 int do_saveenv (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
    547 {
    ...
    553 }
    554
    555
    556 #endif

In other words: in your configuration there is not even an  implemen-
tation of the saveenv() function, so why bother?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You go slow, be gentle. It's no one-way street -- you  know  how  you
feel and that's all. It's how the girl feels too. Don't press. If the
girl feels anything for you at all, you'll know.
	-- Kirk, "Charlie X", stardate 1535.8