[U-Boot-Users] [PATCH] fix BRCM570x related bugs

[Vadim Bendebury]

Wolfgang,

thank you for a quick reply. Sorry for not following the coding
conventions, I'll address this concern, I am more worried why there
are so many patch failures. What's the revision of the file you're
applying the patch against and what is the exact patch command you're
using?

cheers,
/vb

On 5/23/07, Wolfgang Denk <wd at denx.de> wrote:
> Dear Vadim,
>
> in message <3b09bd800705231630m97ffa48hbaa1c71f3a5f002 at mail.gmail.com> you wrote:
> > This fixes numerous bugs in the u-boot bcm570x driver implementation.
> > The way the driver exists in u-boot before this fix, it allows to ping
> > a host o few times, but could never complete a tftp transfer of a
> > kernel image.
>
> Please read http://www.denx.de/wiki/UBoot/CodingStyle and fix your
> patch (and the driver).
>
> Biggest problem: your patch does not apply at all:
>
> -> patch -p1 --dry-run </tmp/0
> patching file drivers/bcm570x.c
> Hunk #1 FAILED at 6.
> Hunk #2 FAILED at 27.
> Hunk #4 FAILED at 123.
> Hunk #6 FAILED at 199.
> Hunk #7 FAILED at 259.
> Hunk #9 FAILED at 370.
> Hunk #10 FAILED at 405.
> Hunk #11 succeeded at 468 with fuzz 1.
> Hunk #12 succeeded at 506 with fuzz 2.
> Hunk #13 FAILED at 528.
> Hunk #14 FAILED at 622.
> Hunk #15 FAILED at 651.
> Hunk #16 FAILED at 671.
> Hunk #17 FAILED at 701.
> Hunk #18 FAILED at 735.
> Hunk #19 succeeded at 1118 with fuzz 2.
> patch: **** malformed patch at line 518: PLM_PACKET pPacket)
>
> Part of the problem is that your mailer corrupted the patch by folding
> long lines.
>
>
> Then, there are many coding style violations in your patch:
> indentation not by TABs, indentation not yu  a multiple of 8 columns,
> spaces missing after function names and after "if" and before "{",
> etc.
>
> Also, I object in changing the NAMESIZE definition in  include/net.h;
> if  16 characters are not enough for your interface names, you should
> shorten the names instead. Nobody  wants  to  type  such  long  names
> anyway.
>
> Also, please break up your  patch  into  orthogonal  and  independent
> patches  - your changes to include/net.h have nothing to do with your
> driver fixes and must be submitted separately.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Save energy:  Drive a smaller shell.
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
>