[U-Boot-Users] [PATCH] fix BRCM570x related bugs

Ben Warren bwarren at qstreams.com
Thu May 24 15:35:26 CEST 2007


Hi Vadim,

--- Vadim Bendebury <vbendeb at yahoo.com> wrote:

> Wolfgang,
> 
> thank you for a quick reply. Sorry for not following the coding
> conventions, I'll address this concern, I am more worried why there
> are so many patch failures. What's the revision of the file you're
> applying the patch against and what is the exact patch command you're
> using?
> 
> cheers,
> /vb

Here are the expectations:

1. Patch will apply against the current git head
2. The command used by custodians is 

  git am --signoff --whitespace=strip < PATCH_FILE

Notice that this strips offending whitespace.  You should take care to not have
any in the first place, though.

I suggest that before sending a patch, you clone the head and try this command.
 That way you can hopefully avoid *some* scorn from Wolfgang.  Speaking of
which... I'll try to preempt him and warn you about top-quoting.  It's
considered bad form.  

Thanks for working on this and we look forward to your patches.

cheers,
Ben




More information about the U-Boot mailing list