[U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx CFG_RAMBOOT

Timur Tabi timur at freescale.com
Thu May 24 17:25:28 CEST 2007


Wolfgang Denk wrote:

> Good idea. Shall we go for that?
> 
> Any other opinions, ACKs or NACKs?

ACK.  I like it.  The header files should all start with the same name, like 
config_defaults.h and config_all.h.  And config_defaults should contain a list of ALL 
options, using #define to turn on options and #undef to turn off options.  Yes, the 
#undefs are redundant, but then you can use that file as a reference.  It would also be 
nice if the documentation for these options were moved from the README to this file.  My 
text editor has the ability to display comments for any identifier if I just however the 
mouse over it.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale




More information about the U-Boot mailing list