[U-Boot-Users] [PATCH] LOGO: Allow each board to define its own logo.

[Wolfgang Denk]

In message <20070527145833.GS21180 at enneenne.com> you wrote:
> This allow developers to define per board logo file into boards' main
> configuration file (board/*/config.mk) as follow:

Sorry, but this is a misconception. The board/*/config.mk  is  NOT  a
configuration  file intended for such settings. The boards' main con-
figuration file is include/configs/<name>.h, and as far  as  possible
all configuration should be set there.

> 	# The logo bitmap
> 	LOGO_BMP = board/<name>/<logo>.bmp
> 
> Signed-off-by: Rodolfo Giometti <giometti at linux.it>
> ---
>  tools/Makefile |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/Makefile b/tools/Makefile
> index 6177f90..ad2824d 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -40,7 +40,7 @@ endif
>  LOGO_H	= $(OBJTREE)/include/bmp_logo.h
>  
>  ifeq ($(LOGO_BMP),)
> -LOGO_BMP= logos/denx.bmp
> +LOGO_BMP= tools/logos/denx.bmp
>  endif
>  
>  #-------------------------------------------------------------------------

Until here, I see no advantage by this patch. I  don't  think  adding
another level of subdirectoris is a win.

> @@ -203,8 +203,8 @@ $(obj)crc32.c:
>  		@rm -f $(obj)crc32.c
>  		ln -s $(src)../lib_generic/crc32.c $(obj)crc32.c
>  
> -$(LOGO_H):	$(obj)bmp_logo $(LOGO_BMP)
> -		$(obj)./bmp_logo $(LOGO_BMP) >$@
> +$(LOGO_H):	$(obj)bmp_logo $(TOPDIR)/$(LOGO_BMP)
> +		$(obj)./bmp_logo $(TOPDIR)/$(LOGO_BMP) >$@

But this is a change to the worse. Before, I could define (for example
on the "make" command line:

	LOGO_BMP=/some/other/path/foo.bmp

which will now break as you unconditionally prefix this setting with
$(TOPDIR).



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It would be illogical to kill without reason
	-- Spock, "Journey to Babel", stardate 3842.4