[U-Boot-Users] [PATCH] LOGO: Allow each board to define its own logo.
Rodolfo Giometti
giometti at enneenne.com
Mon May 28 09:52:37 CEST 2007
On Sun, May 27, 2007 at 10:58:25PM +0200, Wolfgang Denk wrote:
> In message <20070527145833.GS21180 at enneenne.com> you wrote:
> > This allow developers to define per board logo file into boards' main
> > configuration file (board/*/config.mk) as follow:
>
> Sorry, but this is a misconception. The board/*/config.mk is NOT a
> configuration file intended for such settings. The boards' main con-
> figuration file is include/configs/<name>.h, and as far as possible
> all configuration should be set there.
But doing like this how can I define the file to supply to the
logo_bmp utility? This settings is needed to get the file
"include/bmp_logo.h" which in turn is used for the compilation stage.
> > ifeq ($(LOGO_BMP),)
> > -LOGO_BMP= logos/denx.bmp
> > +LOGO_BMP= tools/logos/denx.bmp
> > endif
> >
> > #-------------------------------------------------------------------------
>
> Until here, I see no advantage by this patch. I don't think adding
> another level of subdirectoris is a win.
This is due the next change.
> > @@ -203,8 +203,8 @@ $(obj)crc32.c:
> > @rm -f $(obj)crc32.c
> > ln -s $(src)../lib_generic/crc32.c $(obj)crc32.c
> >
> > -$(LOGO_H): $(obj)bmp_logo $(LOGO_BMP)
> > - $(obj)./bmp_logo $(LOGO_BMP) >$@
> > +$(LOGO_H): $(obj)bmp_logo $(TOPDIR)/$(LOGO_BMP)
> > + $(obj)./bmp_logo $(TOPDIR)/$(LOGO_BMP) >$@
>
> But this is a change to the worse. Before, I could define (for example
> on the "make" command line:
>
> LOGO_BMP=/some/other/path/foo.bmp
>
> which will now break as you unconditionally prefix this setting with
> $(TOPDIR).
I see...
I'm trying to find a good way to allow developers to define their own
logos since currently only denx.bmp is used in a not configurable way
(or at least I didn't find it).
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti at enneenne.com
Linux Device Driver giometti at gnudd.com
Embedded Systems giometti at linux.it
UNIX programming phone: +39 349 2432127
More information about the U-Boot
mailing list