[U-Boot-Users] Spartan FPGA patch

[Wolfgang Denk]

In message <472752F9.9000307 at inaccessnetworks.com> you wrote:
>
> The following patch fixes a bug in the slave serial programming mode for 
> the xilinx spartan2 FPGA. A "char val" is declared, but it is used as a 
> signed char. The check for negative value (<0) is always true on arm, or 
> any other platform in which the char is not signed by default. As a 
> result the FPGA cannot be programmed.

I have to admit that I hate to see "signed  char"  in  the  code.  Is
there  any  special  reaso why "val" has to be a "char" type? Why not
making it an "int" ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
8 Catfish                                               = 1 Octo-puss