[U-Boot-Users] [PATCH 1/2 (resubmit)] NET: Cosmetic changes
Wolfgang Denk
wd at denx.de
Sat Nov 3 22:56:52 CET 2007
In message <4728AB89.80205 at arlinx.com> you wrote:
> - int (* read)(char *devname, unsigned char addr,
> - unsigned char reg, unsigned short *value);
> - int (* write)(char *devname, unsigned char addr,
> - unsigned char reg, unsigned short value);
The old code used TAB for indentation. Good.
> + int (*read) (char *devname, unsigned char addr,
> + unsigned char reg, unsigned short *value);
> + int (*write) (char *devname, unsigned char addr,
> + unsigned char reg, unsigned short value);
Now you add to the file size by indeting with characters which is,
strictly speaking, a violation of the Coding Style).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have yet to add the ESP-driver to the kernel to read the mind of
the user... - Linus Torvalds in
<Pine.LNX.3.91.960426110644.24860I-100000 at linux.cs.Helsinki.FI>
More information about the U-Boot
mailing list