[U-Boot-Users] [PATCH 1/2 (resubmit)] NET: Cosmetic changes

Larry Johnson lrj at arlinx.com
Mon Nov 5 00:27:47 CET 2007


Wolfgang Denk wrote:
> In message <4728AB89.80205 at arlinx.com> you wrote:
>> -	int (* read)(char *devname, unsigned char addr,
>> -			unsigned char reg, unsigned short *value);
>> -	int (* write)(char *devname, unsigned char addr,
>> -			unsigned char reg, unsigned short value);
> 
> The old code used TAB for indentation. Good.
> 
>> +	int (*read) (char *devname, unsigned char addr,
>> +		     unsigned char reg, unsigned short *value);
>> +	int (*write) (char *devname, unsigned char addr,
>> +		      unsigned char reg, unsigned short value);
> 
> Now you add to the file size by indeting with characters which is,
> strictly speaking, a violation of the Coding Style).
> 
> 
> Best regards,
> 
> Wolfgang Denk

Hi Wolfgang,

Unfortunately, it was "Lindent" that broke the indentation.  Apparently,
when a parameter list to a function call doesn't fit on a line, it tries
to line up additional parameters beneath the first one.

I could search for and fix these cases, but it would defeat the purpose
of posting these cosmetic changes, which was so that the next time
someone uses "Lindent" on the file to check modifications, he or she
won't get a bunch of changes to the unmodified parts of the code.

Best regards,
Larry





More information about the U-Boot mailing list