[U-Boot-Users] [PATCH 0/1] Fix warning: passing argument 1 of 'move64' discards qualifiers from pointer target type

[Wolfgang Denk]

In message <1195504030-17994-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> 
> diff --git a/post/drivers/memory.c b/post/drivers/memory.c
> index fbc349a..bf16157 100644
> --- a/post/drivers/memory.c
> +++ b/post/drivers/memory.c
> @@ -207,7 +207,7 @@ static void move64(unsigned long long *src, unsigned long long *dest)
>   * than the test pattern.  This is for detecting floating bus lines.
>   *
>   */
> -const static unsigned long long pattern[] = {
> +static unsigned long long pattern[] = {
>  	0xaaaaaaaaaaaaaaaaULL,
>  	0xccccccccccccccccULL,
>  	0xf0f0f0f0f0f0f0f0ULL,
> @@ -221,7 +221,7 @@ const static unsigned long long pattern[] = {
>  	0x3333333333333333ULL,
>  	0x5555555555555555ULL
>  };
> -const unsigned long long otherpattern = 0x0123456789abcdefULL;
> +unsigned long long otherpattern = 0x0123456789abcdefULL;

This patch seems technically wrong to me. This data *is* constant.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I've seen it. It's rubbish."          - Marvin the Paranoid Android