[U-Boot-Users] [PATCH 1/1] Fix warning: passing argument 1 of 'fpga_boot' discards qualifiers from pointer target type

Wolfgang Denk wd at denx.de
Tue Nov 20 00:56:11 CET 2007


In message <1195504030-17994-2-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> 
> diff --git a/board/esd/canbt/canbt.c b/board/esd/canbt/canbt.c
> index 055a397..e0f9c57 100644
> --- a/board/esd/canbt/canbt.c
> +++ b/board/esd/canbt/canbt.c
> @@ -39,7 +39,7 @@ extern int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]);
>  #endif
>  
>  /* fpga configuration data */
> -const unsigned char fpgadata[] = {
> +unsigned char fpgadata[] = {
>  #include "fpgadata.c"
>  };
>  
> diff --git a/board/esd/cpci405/cpci405.c b/board/esd/cpci405/cpci405.c
> index 69cb8ce..059c48a 100644
> --- a/board/esd/cpci405/cpci405.c
> +++ b/board/esd/cpci405/cpci405.c
> @@ -37,7 +37,7 @@ extern int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]);	/*cmd_
>  #endif
>  
>  /* fpga configuration data - generated by bin2cc */
> -const unsigned char fpgadata[] =
> +unsigned char fpgadata[] =
>  {
>  #ifdef CONFIG_CPCI405_VER2
>  # ifdef CONFIG_CPCI405AB
> diff --git a/board/esd/cpciiser4/cpciiser4.c b/board/esd/cpciiser4/cpciiser4.c
> index fcb8cbb..c4f5d09 100644
> --- a/board/esd/cpciiser4/cpciiser4.c
> +++ b/board/esd/cpciiser4/cpciiser4.c
> @@ -45,7 +45,7 @@ extern void lxt971_no_sleep(void);
>  #endif
>  
>  /* fpga configuration data - generated by bin2cc */
> -const unsigned char fpgadata[] = {
> +unsigned char fpgadata[] = {
>  #include "fpgadata.c"
>  };
>  
> diff --git a/board/esd/du405/du405.c b/board/esd/du405/du405.c
> index 6943213..9450cda 100644
> --- a/board/esd/du405/du405.c
> +++ b/board/esd/du405/du405.c
> @@ -45,7 +45,7 @@ extern void lxt971_no_sleep(void);
>  #endif
>  
>  /* fpga configuration data - generated by bin2cc */
> -const unsigned char fpgadata[] = {
> +unsigned char fpgadata[] = {
>  #include "fpgadata.c"
>  };

May I ask what your rationale is for these changes? This *is* constant
data, so why do you make these changes?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nothing in progression can rest on its original plan. We may as  well
think  of  rocking  a grown man in the cradle of an infant.
- Edmund Burke




More information about the U-Boot mailing list