[U-Boot-Users] [GIT PULL] [ARM] Please pull from git://denx.de/git/u-boot-arm.git

Wolfgang Denk wd at denx.de
Sat Sep 15 21:22:40 CEST 2007

Dear Peter,

in message <000001c7f488$c4d288d0$9a4d010a at Emea.Arm.com> you wrote:
> > The following issues need to be addressed:
> > include/led.h => seems specific to the at91rm9200dk board only,
> >                  please move to board directory. Also, the calls to
> >                  these functions should be handled without #ifdef's
> >                  in common code. Either use existing functions hooks,
> >                  or weak references.
> Moved to asm-arm as coloured_led.h 

I still would rather have this integrated into the existing status_led

> - I want to play with the coloured leds on other ARM boards sometime.

Please feel free to do so.

> > drivers/at45.c => has coding style issues - indentation of long,
> >                   wrapped around lines is broken.
> - ran Lindent on it

Actually the new version is even worse. It has many lines which are
not indented by multiple of 8 chars.

Please clean this up.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are two ways to write error-free programs. Only the  third  one

More information about the U-Boot mailing list