[U-Boot-Users] [PATCH]: Reset issue fix on mpc85xx

Wolfgang Denk wd at denx.de
Mon Sep 17 22:51:41 CEST 2007


In message <20070917171525.GA3711 at GNU> you wrote:
> Hello,
>   I tried the v1.3.0-rc1 on the ADS board, and problem of the board
>   reset through the 'reset' command pertains. I'm still not sure about
>   the reason of the MSR getting cleared, but am using a brute force
>   approach. 
> 
> Signed-off-by: Sughosh Ganu <urwithsughosh at gmail.com>
> 
> 
> diff --git a/cpu/mpc85xx/cpu.c b/cpu/mpc85xx/cpu.c
> index 08e0468..bbc5444 100644
> --- a/cpu/mpc85xx/cpu.c
> +++ b/cpu/mpc85xx/cpu.c
> @@ -163,7 +163,12 @@ int do_reset (cmd_tbl_t *cmdtp, bd_t *bd, int flag, int argc, char *argv[])
>          * Initiate hard reset in debug control register DBCR0
>          * Make sure MSR[DE] = 1
>          */
> -               unsigned long val;
> +               unsigned long val, msr;
> +
> +               msr = mfmsr ();
> +               msr |= MSR_DE;
> +               mtmsr (msr);
> +
>                 val = mfspr(DBCR0);
>                 val |= 0x70000000;
>                 mtspr(DBCR0,val);

You have whitespace problems with your patch. It does not apply.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I still miss my ex-wife, but my aim is getting better.




More information about the U-Boot mailing list