[U-Boot-Users] [PATCH/review] Blackfin: tighten up post memory coding style

Wolfgang Denk wd at denx.de
Wed Apr 9 09:25:20 CEST 2008


In message <1207722800-3978-6-git-send-email-vapier at gentoo.org> you wrote:
...
> -	for (i = 0; i < 0x80000; i++) ;
> +	for (i = 0; i < 0x80000; i++)
> +		continue;

We don't do this. If you want to make obvious that this is an empty
loop, please write it ias

	for (i = 0; i < 0x80000; i++) 
		;
	
But no "continue".

> -	for (i = 0; i < 0x80000; i++) ;
> +	for (i = 0; i < 0x80000; i++)
> +		continue;
>  }

Ditto.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Old programmers never die, they just branch to a new address.




More information about the U-Boot mailing list