[U-Boot-Users] [PATCH/review] Blackfin: tighten up post memory coding style

Mike Frysinger vapier at gentoo.org
Wed Apr 9 17:29:46 CEST 2008


On Wednesday 09 April 2008, Wolfgang Denk wrote:
> In message <1207722800-3978-6-git-send-email-vapier at gentoo.org> you wrote:
> ...
>
> > -	for (i = 0; i < 0x80000; i++) ;
> > +	for (i = 0; i < 0x80000; i++)
> > +		continue;
>
> We don't do this. If you want to make obvious that this is an empty
> loop, please write it ias
>
> 	for (i = 0; i < 0x80000; i++)
> 		;
>
> But no "continue".
>
> > -	for (i = 0; i < 0x80000; i++) ;
> > +	for (i = 0; i < 0x80000; i++)
> > +		continue;
> >  }
>
> Ditto.

the generated code is the same.  the usage of "continue" makes it much more 
explicit that this is an empty loop.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080409/0d03908a/attachment.pgp 


More information about the U-Boot mailing list