[U-Boot-Users] [PATCH] Move init_sequence table into code.

Wolfgang Denk wd at denx.de
Mon Apr 14 03:09:36 CEST 2008


In message <1206719159-11200-1-git-send-email-Joakim.Tjernlund at transmode.se> you wrote:
> Global variables are not ideal before relocation to RAM.

Byt they don't cause any real problem either, or am I missing
something?

I tend to reject the patch.

> -init_fnc_t *init_sequence[] = {

The original idea of having such a list  of  funtion  pointers  which
just  get executed one after another was to be able to wrap this into
some "#ifndef CONFIG_INIT_SEQUENCE" and use this to allow for  board-
specific init sequences by just adding a #define with the needed list
of functions to the board config files.

Even though this feature never was used so far, I still  hesitate  to
throw  it away - at least as long as I don't see benefits for the new
solution.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Never worry about theory as long as  the  machinery  does  what  it's
supposed to do.                                      - R. A. Heinlein




More information about the U-Boot mailing list