[U-Boot-Users] [PATCH] Move init_sequence table into code.

[Joakim Tjernlund]

On Mon, 2008-04-14 at 03:09 +0200, Wolfgang Denk wrote:
> In message <1206719159-11200-1-git-send-email-Joakim.Tjernlund at transmode.se> you wrote:
> > Global variables are not ideal before relocation to RAM.
> 
> Byt they don't cause any real problem either, or am I missing
> something?

Makes u-boot smaller too.
It is a step closer towards full relocation of u-boot, I want to get rid
of using global data while in FLASH.

> 
> I tend to reject the patch.
> 
> > -init_fnc_t *init_sequence[] = {
> 
> The original idea of having such a list  of  funtion  pointers  which
> just  get executed one after another was to be able to wrap this into
> some "#ifndef CONFIG_INIT_SEQUENCE" and use this to allow for  board-
> specific init sequences by just adding a #define with the needed list
> of functions to the board config files.

You can do that with weak functions too. Just make all the functions
weak, then a board can overide with its own function.

> 
> Even though this feature never was used so far, I still  hesitate  to
> throw  it away - at least as long as I don't see benefits for the new
> solution.
> 
> Best regards,
> 
> Wolfgang Denk
>