[U-Boot-Users] [PATCH v2 3/7] add an i2c driver for mx31

Kumar Gala galak at kernel.crashing.org
Mon Apr 14 16:02:01 CEST 2008


On Apr 14, 2008, at 1:46 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 20:40 Wed 26 Mar     , Guennadi Liakhovetski wrote:
>> From: Sascha Hauer <s.hauer at pengutronix.de>
>>
>> This patch adds an i2c driver for Freescale i.MX processors
>>
>> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
>> Signed-off-by: Guennadi Liakhovetski <lg at denx.de>
>>
>> ---
>>
>> No changes wrt v1
>>
>> drivers/i2c/Makefile  |    1 +
>> drivers/i2c/mxc_i2c.c |  202 +++++++++++++++++++++++++++++++++++++++ 
>> ++++++++++
>> 2 files changed, 203 insertions(+), 0 deletions(-)
>> create mode 100644 drivers/i2c/mxc_i2c.c
>>
>> diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
>> index 29d6c03..071ef00 100644
>> --- a/drivers/i2c/Makefile
>> +++ b/drivers/i2c/Makefile
>> @@ -29,6 +29,7 @@ COBJS-y += fsl_i2c.o
>> COBJS-y += omap1510_i2c.o
>> COBJS-y += omap24xx_i2c.o
>> COBJS-y += tsi108_i2c.o
>> +COBJS-y += mxc_i2c.o
>>
>> COBJS	:= $(COBJS-y)
>> SRCS 	:= $(COBJS:.o=.c)
>> diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
>> new file mode 100644
>> index 0000000..a218329
>> --- /dev/null
>> +++ b/drivers/i2c/mxc_i2c.c
>> @@ -0,0 +1,202 @@
>> +/*
>> + * i2c driver for Freescale mx31
>> + *
>> + * (c) 2007 Pengutronix, Sascha Hauer <s.hauer at pengutronix.de>
>> + *
>> + * See file CREDITS for list of people who contributed to this
>> + * project.
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of
>> + * the License, or (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>> + * MA 02111-1307 USA
>> + */
>> +
>> +#include <common.h>
>> +
>> +#if defined(CONFIG_HARD_I2C) && defined (CONFIG_I2C_MXC)
> Please stop to define this here, move it the Makefile
>
> Wolfgang,
> Is it possible to NACK all patch that add new driver that do this

Also, I believe the imx I2C is the same as the PPC I2C HW.  I havent  
verified this but the register set looks oddly identical.

- k




More information about the U-Boot mailing list