[U-Boot-Users] [PATCH v2 3/7] add an i2c driver for mx31

[Wolfgang Denk]

In message <20080414064659.GB17663 at game.jcrosoft.org> you wrote:
>
> > +#if defined(CONFIG_HARD_I2C) && defined (CONFIG_I2C_MXC)
> Please stop to define this here, move it the Makefile

Hm... While I agree with the simple standard case of a single
"#ifdef", I'm not so 100% sure it is a good thing to add such complex
expressions to the Makefile.

Aren't we just moving the #ifdef hell from one place to another?

> Wolfgang,
> Is it possible to NACK all patch that add new driver that do this

You mean, automatically? I would not know how to do that.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Deliver yesterday, code today, think tomorrow."