[U-Boot-Users] [patch 1/1] (V2) Set GD_FLG_RELOC for boards skipping relocation to RAM

[Magnus Lilja]

Hi

On Wed, Jul 30, 2008 at 12:13 AM, Wolfgang Denk <wd at denx.de> wrote:
> In message <20080722142321.319882523 at bohmer.net>> you wrote:
>> If CONFIG_SKIP_RELOCATE_UBOOT is set the flag GD_FLG_RELOC is usually never
>> set, because relocation to RAM is actually never done by U-boot itself.
>> However, several pieces of code check if this flag is set at some time.
>>
>> So, to make sure this flag is set on boards skipping relocation, this
>> is added to the initialisation of U-boot at a moment where it is safe
>> to do so.
>>
>> V2: Forgot to add 'return 0;' to reloc_init() routine.
>>
>> Signed-off-by: Remy Bohmer <linux at bohmer.net>
>> ---
>>  lib_arm/board.c |   17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>
> Applied, thanks.

To me it seems like GD_FLG_RELOC is not set unless
CONFIG_SKIP_RELOCATE_UBOOT is set. Other boards (mips, ppc etc) set
GD_FLG_RELOC in their board_init_r function but as far as I can see
this does not happen for ARM boards. Shouldn't it be set in
lib_arm/board.c:start_armboot right after the gd pointer has been
initialized?

I just took the latest git tree and built an i.MX31 Litekit binary
(with defining CONFIG_SKIP_RELOCATE_UBOOT) and GD_FLG_RELOC is not set
after boot.

Thanks, Magnus