[U-Boot-Users] [PATCH] Fill in remaining MTD driver data for OneNAND (take #2)

Fathi BOUDRA fabo at debian.org
Wed Aug 6 18:32:04 CEST 2008


> Don't cast the return of malloc.

ok.

> Why not just declare a static array?

I tried with a static array but it doesn't give the expected result (a quick 
test with onenand info command returns an empty mtd name), so I used a 
pointer.

> It'd be better to use snprintf, even if you're pretty sure it won't
> overflow.

I tried it too :) U-Boot doesn't have snprintf or asprintf or I missed 
something.

Do I need to re-submit the patch only for cast ?

cheers,

Fathi





More information about the U-Boot mailing list