[U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

[Magnus Lilja]

Hi,

On Wed, Aug 6, 2008 at 11:49 PM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj at jcrosoft.com> wrote:
> On 14:19 Wed 06 Aug     , Magnus Lilja wrote:
>> Add support for NAND and ethernet on the Freescale i.MX31 PDK (a.k.a.
>> 3DS) board.
>>
>> Booting from NAND is not supported yet so U-boot relies on some other
>> initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM.
>>
>> Signed-off-by: Magnus Lilja <lilja.magnus at gmail.com>
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -2683,6 +2683,9 @@ imx31_phycore_config    : unconfig
>>  mx31ads_config               : unconfig
>>       @$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads NULL mx31
>>
>> +mx31pdk_config               : unconfig
>> +     @$(MKCONFIG) $(@:_config=) arm arm1136 mx31pdk NULL mx31
>> +
> I've just send a patch to move all freescale's mx31 board to vendor dir
>
> so please replace with
> +mx31pdk_config         : unconfig
> +       @$(MKCONFIG) $(@:_config=) arm arm1136 mx31pdk freescale mx31
> +
>>  omap2420h4_config    : unconfig
>>       @$(MKCONFIG) $(@:_config=) arm arm1136 omap2420h4 NULL omap24xx
>>
>> diff --git a/board/mx31pdk/Makefile b/board/mx31pdk/Makefile
> and move your board to
> board/freescale/mx31pdk/

Ok.

<snip>
>> +#define CONFIG_DISPLAY_CPUINFO
>> +#define CONFIG_DISPLAY_BOARDINFO
>> +
>> +/* Temporarily disabled */
>> +#if 0
>> +#define CONFIG_OF_LIBFDT             1
>> +#define CONFIG_FIT                   1
>> +#define CONFIG_FIT_VERBOSE           1
>> +#endif
> so please remove

Ok.

>> +#define CONFIG_CMD_SPI
>> +#define CONFIG_CMD_DATE
>> +
>> +#define CONFIG_CMD_NAND 1
> why not
> #define CONFIG_CMD_NAND
>
> the check is ifdef

Ok.

>> +#define CFG_HZ                       CONFIG_MX31_CLK32
>> +
>> +#define CONFIG_CMDLINE_EDITING       1
>> +
>> +#undef CONFIG_CMD_IMLS
> please regroup CONFIG_CMD_*

Ok.


Thanks, Magnus