[U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

[Wolfgang Denk]

In message <1218025165-11847-6-git-send-email-lilja.magnus at gmail.com> you wrote:
> Add support for NAND and ethernet on the Freescale i.MX31 PDK (a.k.a.
> 3DS) board.
> 
> Booting from NAND is not supported yet so U-boot relies on some other
> initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM.
> 
> Signed-off-by: Magnus Lilja <lilja.magnus at gmail.com>
...
> --- /dev/null
> +++ b/include/configs/mx31pdk.h
> @@ -0,0 +1,186 @@
...
> +
> +#undef	CFG_CLKS_IN_HZ		/* everything, incl board info, in Hz */

Please remove that line. Makes no sense to undef what doesn't exist.

> +#define CFG_LOAD_ADDR		0x81000000 /* default load address */
> +
> +#define CFG_HZ			CONFIG_MX31_CLK32
> +
> +#define CONFIG_CMDLINE_EDITING	1
> +
> +#undef CONFIG_CMD_IMLS

Why do you want to disable the "imls" command?


...
> +#undef CONFIG_JFFS2_CMDLINE

Why do you disable this?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The first thing we do is kill all the lawyers.
(Shakespeare. II Henry VI, Act IV, scene ii)