[U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

[Magnus Lilja]

Hi

On Thu, Aug 7, 2008 at 12:05 AM, Wolfgang Denk <wd at denx.de> wrote:
> In message <1218025165-11847-6-git-send-email-lilja.magnus at gmail.com> you wrote:
>> Add support for NAND and ethernet on the Freescale i.MX31 PDK (a.k.a.
>> 3DS) board.
>>
>> Booting from NAND is not supported yet so U-boot relies on some other
>> initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM.
>>
>> Signed-off-by: Magnus Lilja <lilja.magnus at gmail.com>
> ...
>> --- /dev/null
>> +++ b/include/configs/mx31pdk.h
>> @@ -0,0 +1,186 @@
> ...
>> +
>> +#undef       CFG_CLKS_IN_HZ          /* everything, incl board info, in Hz */
>
> Please remove that line. Makes no sense to undef what doesn't exist.

Ok (quite a number of board configs have this #undef and some have a
#define CFG_CLKS_IN_HZ).

>> +#define CFG_LOAD_ADDR                0x81000000 /* default load address */
>> +
>> +#define CFG_HZ                       CONFIG_MX31_CLK32
>> +
>> +#define CONFIG_CMDLINE_EDITING       1
>> +
>> +#undef CONFIG_CMD_IMLS
>
> Why do you want to disable the "imls" command?

Because I get compilation errors from cmd_bootm.c if it's enabled. I
haven't checked the details but perhaps it's because there is no NOR
flash defined in this config (no NOR present on the PDK board).

> ...
>> +#undef CONFIG_JFFS2_CMDLINE
>
> Why do you disable this?

Probably a leftover from either a compilation problem or copy&pasted
from the config file I started with (some other i.MX31 board). I'll
remove the line if I don't run into problems, it seems to compile OK
if I remove the line.


Thanks, Magnus