[U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

[Wolfgang Denk]

In message <59b21cf20808070456vb8452at5717b580b630e7cc at mail.gmail.com> you wrote:
> 
> >> +#undef       CFG_CLKS_IN_HZ          /* everything, incl board info, in Hz */
> >
> > Please remove that line. Makes no sense to undef what doesn't exist.
> 
> Ok (quite a number of board configs have this #undef and some have a
> #define CFG_CLKS_IN_HZ).

I know, but it makes no sense to copy bad style.

> >> +#undef CONFIG_CMD_IMLS
> >
> > Why do you want to disable the "imls" command?
> 
> Because I get compilation errors from cmd_bootm.c if it's enabled. I
> haven't checked the details but perhaps it's because there is no NOR
> flash defined in this config (no NOR present on the PDK board).

Ah! This is an indication of a problem with your board. You rather fix
this. "imls" is a standard command, and if you have to disablke it to
compile U-Boot, then something is broken.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The POP3 server service depends on the SMTP  server  service,  which
failed to start because of the following error: The operation comple-
ted successfully."                         -- Windows NT Server v3.51