[U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

[Magnus Lilja]

On Thu, Aug 7, 2008 at 2:18 PM, Wolfgang Denk <wd at denx.de> wrote:
> In message <59b21cf20808070456vb8452at5717b580b630e7cc at mail.gmail.com> you wrote:
>> >> +#undef CONFIG_CMD_IMLS
>> >
>> > Why do you want to disable the "imls" command?
>>
>> Because I get compilation errors from cmd_bootm.c if it's enabled. I
>> haven't checked the details but perhaps it's because there is no NOR
>> flash defined in this config (no NOR present on the PDK board).
>
> Ah! This is an indication of a problem with your board. You rather fix
> this. "imls" is a standard command, and if you have to disablke it to
> compile U-Boot, then something is broken.


Well, I wonder if that's the case here. cmd_bootm.c needs the
flash_info_t datatype (amongst other things) when CONFIG_CMD_IMLS is
enabled. flash_info_t is found in include/flash.h but within a #ifndef
CFG_NO_FLASH. CFG_NO_FLASH is, as far as I can see, defined for boards
that don't have any NOR flash.

I haven't looked at all the config files for the boards that undef
CONFIG_CMD_IMLS but at least a couple of AT91SAM926x and Davinci
boards with only NAND flash present do this.


Regards, Magnus