[U-Boot] [PATCH] ppc4xx: Read pipeline depth set to 4 for PPC440SP/SPE, PPC405EX, PPC460EX/GT/SX processors

[Wolfgang Denk]

Dear Stefan Roese,

In message <200808130826.57511.sr at denx.de> you wrote:
>
> > > +/* PLB4 CrossBar Arbiter Core supported across PPC4xx families */
> > > +#if defined(CONFIG_440EP) || defined(CONFIG_440EPX) || \
> > > +    defined(CONFIG_440GR) || defined(CONFIG_440GRX) || \
> > > +    defined(CONFIG_440SP) || defined(CONFIG_440SPE) || \
> > > +    defined(CONFIG_460EX) || defined(CONFIG_460GT)  || \
> > > +    defined(CONFIG_460SX) || defined(CONFIG_405EX)
--------------------------------------------^^^^^^^^^^^^^
...
> > Here you move 44x specific code from a 44x specific header file into a
> > 4xx generic header file which requires you to add a 44x specific
> > #ifdef's.
> 
> These defines are also used on the 405EX (and possibly future 405 variants as 
> well). It makes sense to move them to ppc4xx.h so we don't have to duplicate 
> those defines in 2 headers. This has been a big problem in the past with the 
> ppc405.h and ppc440.h headers.

You are right, I missed that single 405 there.

May I please ask to sort the list, then?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Let's say the docs present a simplified view of reality...    :-)
                      - Larry Wall in  <6940 at jpl-devvax.JPL.NASA.GOV>