[U-Boot] [PATCH] ppc4xx: Read pipeline depth set to 4 for PPC440SP/SPE, PPC405EX, PPC460EX/GT/SX processors
prodyut hazarika
prodyuth at gmail.com
Wed Aug 13 21:04:54 CEST 2008
Dear Wolfgang,
Please see comments below.
> > But then, you are changing good TAB chanracters that were used for
> > vertical alignment into spaces. This is incorrect - please read the
> > Coding Style requirements.
> >
> > Please do not do this.
The problem is that lot of existing code use spaces to align the
defines. You can see include/ppc4xx.h and lot of other header files. I
have seen that spaces are used only in defines. As an example in
ppc4xx.h. I can send thousands of other places.:
#if defined(CONFIG_405EX) || \$
defined(CONFIG_440SP) || defined(CONFIG_440SPE) || \$
defined(CONFIG_460EX) || defined(CONFIG_460GT)$
#define CONFIG_SDRAM_PPC4xx_IBM_DDR2^I/* IBM DDR(2) controller */$
#endif$
More information about the U-Boot
mailing list