[U-Boot] [PATCH] ppc4xx: Read pipeline depth set to 4 for PPC440SP/SPE, PPC405EX, PPC460EX/GT/SX processors
Prodyut Hazarika
phazarika at amcc.com
Wed Aug 13 21:16:02 CEST 2008
Dear Wolfgang,
One more comment.
> > But then, you are changing good TAB chanracters that were used
> > for vertical alignment into spaces. This is incorrect - please
> > read the Coding Style requirements.
> >
> > Please do not do this.
I basically moved the defines from include/ppc440.h to include/ppc4xx.h.
If you go to include/ppc440.h, you will see that the original define was aligned
With spaces. I just followed whatever was it.
Here is the original code in ppc440.h
#if defined(CONFIG_440EP) || defined (CONFIG_440GR) || \
^^ space here ^^ space here
defined(CONFIG_440EPX) || defined(CONFIG_440GR)
^^^^^space here
Please advice what is the best way to proceed. As you can see, this is certainly not my invention.
Regards,
Prodyut Hazarika
=====================
Staff S/w Engineer
=====================
--------------------------------------------------------
CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to Applied Micro Circuits Corporation or its subsidiaries. It is to be used solely for the purpose of furthering the parties' business relationship. All unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.
More information about the U-Boot
mailing list