[U-Boot] [new uImage] Cleanup cmd_bootm.c

Wolfgang Denk wd at denx.de
Tue Aug 19 17:10:08 CEST 2008


Dear Marian,

in commit 1ee1180b you added code to common/cmd_bootm.c which uses the
env_get_char() function. By then, this went through unnoticed.

I'm sorry, but env_get_char() is a function that is internal  to  the
environment  handling  code.  It  is  not  supposed to be exported to
arbitrary  code.  Please  do  not  make  any  assumptions  about  the
internals of how the environment is stored.

Could you please provide a cleanup patch?

Thanks in advance.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There's only one way to have a happy marriage and as soon as I learn
what it is I'll get married again."                  - Clint Eastwood



More information about the U-Boot mailing list