[U-Boot] [POWERPC] TQM8272: Fix compiling error for the TQM8272 board.

[Heiko Schocher]

Hello Stefan,

Stefan Roese wrote:
> On Wednesday 27 August 2008, Heiko Schocher wrote:
> 
> <snip>
> 
>> +++ b/board/tqc/tqm8272/tqm8272.c
>> @@ -1066,38 +1066,24 @@ int update_flash_size (int flash_size)
>>  #include <nand.h>
>>  #include <linux/mtd/mtd.h>
>>
>> -static u8 hwctl = 0;
>> -
>>  static void upmnand_hwcontrol(struct mtd_info *mtd, int cmd, unsigned int
>> ctrl) {
>>  	struct nand_chip *this = mtd->priv;
>> +	ulong base = (ulong) (this->IO_ADDR_W + chipsel * CFG_NAND_CS_DIST);
>> +	unsigned char byte = (unsigned char) cmd;
> 
> You have integrated this NAND driver into the tqm8272.c source file. I suggest 
> you move this at some time into the drivers/mtd/nand directory. Is it a 

Why? That are just the boardspecific routines, not a complete NAND driver!

> TQM8272 specific driver? Or is this MPC8xxx specific? From the name of the 
> functions (upm_xxx) this seems to match the already available driver under:
> 
> drivers/mtd/nand/fsl_upm.c
> 
> Is it possible that you can use this common FSL-UPM version?

Maybe this is posible, but without the Hardware to try this new
version, I dont like to make such a "big" change ...

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany