[U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

Liew Tsi Chung-R5AAHP Tsi-chung.Liew at freescale.com
Thu Aug 28 19:06:14 CEST 2008


Scott,

	I do have -i8 included. So, which one I should edit by hand? The
" }," or " .xxxx =".

Regards,
TsiChung

-----Original Message-----
From: Wood Scott-B07421 
Sent: Thursday, August 28, 2008 12:01 PM
To: Liew Tsi Chung-R5AAHP
Cc: Haavard Skinnemoen; U-Boot; Rigby John-R61273; Jason McMullan
Subject: Re: [U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

On Thu, Aug 28, 2008 at 06:44:56AM -0700, Liew Tsi Chung-R5AAHP wrote:
> >> +	{
> >> +	 .idcode1 = STM_ID_M25P80,
> >> +	 .page_size = 256,
> >> +	 .pages_per_sector = 256,
> >> +	 .nr_sectors = 16,
> >> +	 .name = "M25P80",
> >> +	 },
> >> +	{
> >> +	 .idcode1 = STM_ID_M25P128,
> >> +	 .page_size = 256,
> >> +	 .pages_per_sector = 1024,
> >> +	 .nr_sectors = 64,
> >> +	 .name = "M25P128",
> >> +	 },
> >> +};
> 
> > The indentation is a bit weird here. Please use tabs only.
> The indentation is generated by "indent -npro -kr -ts8 -sob -l80 -ss 
> -ncs "$@"".

Try adding "-i8".  If it still spits out anything looking like the above
with the options you said you used, it's broken and you should do the
formatting by hand.

-Scott


More information about the U-Boot mailing list