[U-Boot] [PATCH] ppc44x: Unification of virtex5 pp440 boards v3

[Stefan Roese]

Ricardo,

sorry that the review took so long. Here we go:

On Wednesday 27 August 2008, Ricardo Ribalda Delgado wrote:
> This patch provides an unificated way of handling xilinx v5 ppc440 boards.

One thing I noticed after applying your patch is the output while running 
MAKEALL:

[stefan at kubuntu u-boot-ppc4xx (master)]$ ./MAKEALL ml507_flash
BOARD_DIR=board/xilinx/ml507 \
        TEXT_BASE=0xFE360000 \
        LINK_SCRIPT=board/xilinx/ppc440-generic/u-boot-rom.lds \
        CONFIG_SCRIPT="ml507 ppc ppc4xx ml507 xilinx" \
        make xilinx_ppc440
make[1]: Entering directory `/home/stefan/git/u-boot/u-boot-ppc4xx'
Configuring for ml507 board...
make[1]: Leaving directory `/home/stefan/git/u-boot/u-boot-ppc4xx'
   text    data     bss     dec     hex filename
 149144    7652   14892  171688   29ea8 ./u-boot

Could you please reduce this output to the "normal" output style:

[stefan at kubuntu u-boot-ppc4xx (master)]$ ./MAKEALL canyonlands
Configuring for canyonlands board...
   text    data     bss     dec     hex filename
 331288   19348  332032  682668   a6aac ./u-boot


And did you check if your patch also has no problems with out-of-tree builds? 
I didn't check, just making sure.

Other than that look good. Please fix the issue mentioned above and resubmit. 
Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================