[U-Boot] [PATCH] ppc44x: Unification of virtex5 pp440 boards v3

[Ricardo Ribalda Delgado]

Hello Stefan

  I did want to reduce the code replication in the Makefile. So I
created a common target called xilinx_ppc440 that uses three
variables: BOARD_DIR,TEXT_BASE (u-boot location), LINK_SCRIPT and
CONFIG_SCRIPT  (to setup board dir and config .h), every board just
setup this variables and run the make command again.

  The weird output is because I do not know how to setup Makefile's
variables and run another target without running make again. I can
change the Makefile to the "normal"  behaviour, but with a lot of code
replication.

  I attach you a Makefile codesnipset:

ml507_flash_config: unconfig
           BOARD_DIR=$(obj)board/xilinx/ml507 \
           TEXT_BASE=0xFE360000 \
           LINK_SCRIPT=$(obj)board/xilinx/ppc440-generic/u-boot-rom.lds \
           CONFIG_SCRIPT="ml507 ppc ppc4xx ml507 xilinx" \
           $(MAKE) xilinx_ppc440

xilinx_ppc440: unconfig
           @mkdir -p $(obj)include $(BOARD_DIR)
           @cp $(LINK_SCRIPT) $(BOARD_DIR)/u-boot.lds
           @echo "TEXT_BASE = $(TEXT_BASE)" > $(BOARD_DIR)/config.mk
           @$(MKCONFIG) $(CONFIG_SCRIPT)


Any suggestions to improve it is more than welcome

                  Best regards




On Fri, Aug 29, 2008 at 03:48, Stefan Roese <sr at denx.de> wrote:
> Ricardo,
>
> sorry that the review took so long. Here we go:
>
> On Wednesday 27 August 2008, Ricardo Ribalda Delgado wrote:
>> This patch provides an unificated way of handling xilinx v5 ppc440 boards.
>
> One thing I noticed after applying your patch is the output while running
> MAKEALL:
>
> [stefan at kubuntu u-boot-ppc4xx (master)]$ ./MAKEALL ml507_flash
> BOARD_DIR=board/xilinx/ml507 \
>        TEXT_BASE=0xFE360000 \
>        LINK_SCRIPT=board/xilinx/ppc440-generic/u-boot-rom.lds \
>        CONFIG_SCRIPT="ml507 ppc ppc4xx ml507 xilinx" \
>        make xilinx_ppc440
> make[1]: Entering directory `/home/stefan/git/u-boot/u-boot-ppc4xx'
> Configuring for ml507 board...
> make[1]: Leaving directory `/home/stefan/git/u-boot/u-boot-ppc4xx'
>   text    data     bss     dec     hex filename
>  149144    7652   14892  171688   29ea8 ./u-boot
>
> Could you please reduce this output to the "normal" output style:
>
> [stefan at kubuntu u-boot-ppc4xx (master)]$ ./MAKEALL canyonlands
> Configuring for canyonlands board...
>   text    data     bss     dec     hex filename
>  331288   19348  332032  682668   a6aac ./u-boot
>
>
> And did you check if your patch also has no problems with out-of-tree builds?
> I didn't check, just making sure.
>
> Other than that look good. Please fix the issue mentioned above and resubmit.
> Thanks.
>
> Best regards,
> Stefan
>
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/