[U-Boot] [PATCH] ppc44x: Unification of virtex5 pp440 boards v3

Wolfgang Denk wd at denx.de
Fri Aug 29 13:41:54 CEST 2008


Dear Ricardo,

in message <aa76a2be0808290416m4d030725oadef47643c90a8b2 at mail.gmail.com> you wrote:

> ml507_flash_config: unconfig
>            BOARD_DIR=$(obj)board/xilinx/ml507 \
>            TEXT_BASE=0xFE360000 \
>            LINK_SCRIPT=$(obj)board/xilinx/ppc440-generic/u-boot-rom.lds \
>            CONFIG_SCRIPT="ml507 ppc ppc4xx ml507 xilinx" \
>            $(MAKE) xilinx_ppc440
> 
> xilinx_ppc440: unconfig
>            @mkdir -p $(obj)include $(BOARD_DIR)
>            @cp $(LINK_SCRIPT) $(BOARD_DIR)/u-boot.lds
>            @echo "TEXT_BASE = $(TEXT_BASE)" > $(BOARD_DIR)/config.mk
>            @$(MKCONFIG) $(CONFIG_SCRIPT)

The Makefile is not the right place to provide configuration
information. It shouls select a target board, and build it, nothing
more.

All board specific configuration information should be  kept  in  the
board  specific files only (please also keep in mind the next one who
has to port Linux to a new board - config information should  not  be
scattered  over  too  many  polaces,  and especially no into common ,
central files).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Change is the essential process of all existence.
	-- Spock, "Let That Be Your Last Battlefield",
	   stardate 5730.2


More information about the U-Boot mailing list