[U-Boot-Users] 440EPX is not booting from 1Gb/128MB NAND flash

Wolfgang Denk wd at denx.de
Tue Feb 12 07:02:46 CET 2008


In message <200802120612.46861.sr at denx.de> you wrote:
>
> This is set to 512 for small page devices and set to 2k for large page 
> devices. So the code can be "selected" via this #if statement:
> 
> #if (CFG_NAND_PAGE_SIZE > 512)

Please use an explicit test instead, i. e. for example

	#if (CFG_NAND_PAGE_SIZE == 2048)

unless you are absolutley sure that all future devices (say, with 8k
or 8k page sizes) will behave identical. Otherwise it will be a mess
to clean up that code later.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
        Ordnung ist die Lust der Vernunft,
        aber Unordnung die Wonne der Phantasie         - Paul Claudel




More information about the U-Boot mailing list