[U-Boot-Users] 440EPX is not booting from 1Gb/128MB NAND flash
Stefan Roese
sr at denx.de
Tue Feb 12 07:11:16 CET 2008
On Tuesday 12 February 2008, Wolfgang Denk wrote:
> > #if (CFG_NAND_PAGE_SIZE > 512)
>
> Please use an explicit test instead, i. e. for example
>
> #if (CFG_NAND_PAGE_SIZE == 2048)
>
> unless you are absolutley sure that all future devices (say, with 8k
> or 8k page sizes) will behave identical. Otherwise it will be a mess
> to clean up that code later.
I got my idea from the current Linux MTD NAND drivers (and U-Boot btw). Here
the distinction between small page and large page devices is done this way:
if (mtd->writesize > 512)
lp..
else
sp..
That's why I still prefer my suggestion.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
More information about the U-Boot
mailing list