[U-Boot-Users] CFI: flash accessor functions used for source read too

[Haavard Skinnemoen]

On Wed, 2 Jan 2008 11:52:52 +0100
Stefan Roese <sr at denx.de> wrote:

> Hi Haavard,
> 
> Wolfgang just noticed that we (you in your original patches and myself in the 
> latest patch) use flash_read8() (etc.) to read from source location too. 
> Since this source is normally not located in FLASH, I'm not so sure anymore 
> if we should use these accessors here too.

Right. I did that just to introduce as few surprises as possible --
originally, the source data was accessed through a volatile pointer, so
converting it to use the accessor functions seemed like the natural
thing to do.

I don't think it's really necessary though. The source data isn't
supposed to change underneath us, so accessing it through a regular,
non-volatile pointer should work just fine.

Haavard