[U-Boot-Users] PATCH: load ixp42x NPE firmware from separate flash block, remove dead code

[Wolfgang Denk]

In message <20071110154411.GA11163 at discworld.dascon.de> you wrote:
> 
> the following patch adds support to move the IXP42X NPE firmware to a
> separate flash block, whose start address is defined in
> CONFIG_IXP4XX_NPE_EXT_UCODE_BASE. Using that, it is possible to build
> NPE-enabled u-boot without copyright problems due to the NPE firmware.
> 
> I have also removed some unused code (#if 0 currently - should we completely
> remove those unused parts?)
> 
> I hope the patch applies, I get whitespace-related differences in the NPE
> files due to trailing whitespace in the original versions.
> 
> Signed-off-by: Michael Schwingen <michael at schwingen.org>

I appreciate this patch, yet I have to NAK it in it's current form.

> diff --git a/cpu/ixp/npe/IxNpeDl.c b/cpu/ixp/npe/IxNpeDl.c
> index ffe355c..572f314 100644
> --- a/cpu/ixp/npe/IxNpeDl.c
> +++ b/cpu/ixp/npe/IxNpeDl.c
> @@ -108,6 +108,7 @@ static BOOL ixNpeDlNpeStarted[IX_NPEDL_NPEID_MAX] ={FALSE, FALSE, FALSE} ;
>  PRIVATE IX_STATUS
>  ixNpeDlNpeInitAndStartInternal (UINT32 *imageLibrary, UINT32 imageId);
>  
> +#if 0
>  /*
>   * Function definition: ixNpeDlMicrocodeImageLibraryOverride
>   */
> @@ -139,6 +140,7 @@ ixNpeDlMicrocodeImageLibraryOverride (UINT32 *clientImageLibrary)
>                       "status = %d\n", status);
>      return status;
>  }
> +#endif
...
> +#if 0
...
> +#endif

etc.

Please don't do this - instead, remove the dead code.

We have a source code management system to track such changes.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
C++ was an interesting and valuable experiment, but we've learned its
lessons and it's time to move on.
                            - Peter Curran in <DCqM4z.BxB at isgtec.com>