[U-Boot-Users] [PATCH 11/13] [new uImage] Coding style cleanup - part 1

[Wolfgang Denk]

In message <20080111143021.8025.70916.stgit at hekate.izotz.org> you wrote:
> common/cmd_autoscript.c
> common/cmd_bootm.c
> common/lynxkdi.c
> 
> - sort and cleanup headers, declarations, etc.
> - group related routines
> - cleanup indentation, white spaces

Be careful!


> -	memmove (cmd, (char *)len_ptr, len);
> +	memmove(cmd, (char *)len_ptr, len);
...
> -	rcode = parse_string_outer (cmd, FLAG_PARSE_SEMICOLON);
> +	rcode = parse_string_outer(cmd, FLAG_PARSE_SEMICOLON);
...
> -					debug ("** exec: \"%s\"\n",
> +					debug("** exec: \"%s\"\n",
...
> -	free (cmd);
> +	free(cmd);

This is not a cleanup, this makes it (IMO) worse. Please undo.


> -	int	arg;
> -	ulong	addr;
> -	int     rcode=0;
> +	int arg;
> +	ulong addr;
> +	int rcode = 0;

Do you really think the new code is better or cleaner? It's just
uglier.

Please undo.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You'll pay to know what you really think."        - J.R. "Bob" Dobbs