[U-Boot-Users] [PATCH 11/13] [new uImage] Coding style cleanup - part 1
Larry Johnson
lrj at acm.org
Sat Jan 12 05:07:15 CET 2008
Wolfgang Denk wrote:
> In message <20080111143021.8025.70916.stgit at hekate.izotz.org> you wrote:
[snip]
>> - int arg;
>> - ulong addr;
>> - int rcode=
>> + int arg;
>> + ulong addr;
>> + int rcode =;
>
> Do you really think the new code is better or cleaner? It's just
> uglier.
>
> Please undo.
>
> Best regards,
>
> Wolfgang Denk
Hi Wolfgang,
I agree the change is uglier. Unfortunately, running a file through
Lindent does this. (My personal coding style uses much more whitespace
than the Linux style, so sometimes I need to run Lindent to remove
spaces my fingers put in automatically.)
Maybe the coding style should be "run 'Lindent -pcs', then undo the
following...". I'll admit that I'm already removing all the tabs that
Lindent inserts before comment in the case of
#endif /* defined(FOO) */
Best regards,
Larry
More information about the U-Boot
mailing list