[U-Boot-Users] [PATCH 11/13] [new uImage] Coding style cleanup - part 1

Marian Balakowicz m8 at semihalf.com
Tue Jan 15 12:04:54 CET 2008


Wolfgang Denk wrote:
> In message <20080111143021.8025.70916.stgit at hekate.izotz.org> you wrote:
>> common/cmd_autoscript.c
>> common/cmd_bootm.c
>> common/lynxkdi.c
>>
>> - sort and cleanup headers, declarations, etc.
>> - group related routines
>> - cleanup indentation, white spaces
> 
> Be careful!
> 
[snip]

> This is not a cleanup, this makes it (IMO) worse. Please undo.
> 
[snip]
> 
> Do you really think the new code is better or cleaner? It's just
> uglier.

Thanks for pointing this out, will fix this.

Cheers,
m.




More information about the U-Boot mailing list